-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chore): optional outline on focus #2801
base: develop
Are you sure you want to change the base?
Conversation
See https://stackoverflow.com/questions/31402576/enable-focus-only-on-keyboard-use-or-tab-press for analysis how big players style it. In #2799 I have described an issue for tab focus for button (and dropdown). As the PR is coded now, it will imply outline for Is there any way how to simply not add |
Sure .ui.button:focus-visible {
outline: revert;
} |
Yes, please add this revert style for buttons and other important components. |
No, are least not now, because that won't fit the FUI default theme and every browser displays that differently. If you want this consistent people should be able to define the outline as desired via changing the less variables in this PR. And there are combinations like labeled input where this would need additional styling to look good. If you don't care about all this, then i suggest to add this as custom css in your app. Putting this hardcoded into FUI ,i can already hear several people scream about the visual change in the next version |
I consider this a bug. One proof - So I propose: |
Here is a default FF style obtained from so Current Fomantic-UI button/dropdown/checkbox UX can be tested on https://dev.atk4.org/demos/form-control/input2.php. |
Description
This PR allows to declare a specific focus outline for some components where the default outline is set to none.
The default will be kept to none because FUI mostly shows focus by providing a different color (e.g. buttons) or would not visually fit.
To reduce CSS selectors only a value != none will be rendered, so by default the CSS output wont change
Now the user can decide to change
@focusOutline
globally in a custom site.variables or individually inside a custom themes {component.variables}I still used the :focus pseudo class instead of :focus-visible as we still support IE11 and and even Safari does only support that since 15.4 and we support the last 4 Safari versions, and we always used :focus everywhere else.
Closes
#2799